ValidationPipe not run for Custom Decorators

[kleingeist]

I'm submitting a...

[ ] Regression 
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

The doc says at https://docs.nestjs.com/custom-decorators#working-with-pipes that custom validators may be used with pipes. The example shows the ValidationPipe. But the the ValidationPipe skips on metadata.type == 'custom' https://github.com/nestjs/nest/blob/master/packages/common/pipes/validation.pipe.ts#L78

Expected behavior

Either the docs should be updated or the validation pipe allowed to run on custom decorators.
Personally i would prefer the latter.

What is the motivation / use case for changing the behavior?

It would be useful to use the validation pipe for custom types instead of duplicating the code.

[kamilmysliwiec]

It's expected behavior. If you want to run validation for custom decorators as well, you can build another ValidationPipe based on the existing one. I believe that I explained the reason why it's not a default behavior in another issue already

[kleingeist]

it's expected behavior. If you want to run validation for custom decorators as well, you can build another ValidationPipe based on the existing one.

i would suggest to add this to the docs or change the example at
https://docs.nestjs.com/custom-decorators#working-with-pipes

from

@Get()
async findOne(@User(new ValidationPipe()) user: UserEntity) {
  console.log(user);
}

to

@Get()
async findOne(@User(new CustomValidationPipe()) user: UserEntity) {
  console.log(user);
}

to prevent misunderstadings

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.