Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: refactor packages structure, remove bundle #1176

Merged
merged 9 commits into from
Oct 17, 2018

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Oct 6, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the new behavior?

An alternative proposal to #1060

  • public API remains the same
  • no breaking changes, 3rd-party packages aren't broken
  • bundle directory no longer exists
  • npm run build builds all packages and puts output files near to ts files
  • npm run prepare fixed
  • npm run build:lib builds all packages and put them into node_modules/sample/integration dirs
  • no errors with npm run build
  • npm run clean removes all d.ts and .js files from packages
  • NPM ignores source code when publishing (.ts)
  • GIT ignores bundle files (.d.ts and .js)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 93.743% when pulling 72616cc on build/refactor into 656ecf8 on master.

@coveralls
Copy link

coveralls commented Oct 6, 2018

Pull Request Test Coverage Report for Build 1149

  • 11 of 12 (91.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 93.666%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-tcp.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 1123: -0.03%
Covered Lines: 2680
Relevant Lines: 2802

💛 - Coveralls

Copy link
Member

@BrunnerLivio BrunnerLivio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This will be a huge step forward. Finally easy to overlook PRs in the future :)

General question:
Will this be a replacement of #1060, or will #1060 be implemented later on?

@kamilmysliwiec kamilmysliwiec merged commit da8612b into master Oct 17, 2018
@@ -1,69 +0,0 @@
import { expect } from 'chai';
import { CACHE_MODULE_OPTIONS } from '../../cache/cache.constants';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do tests needed to be updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was something wrong with it (probably cache dir name heh)

@kamilmysliwiec
Copy link
Member Author

I think that it should be enough since it solves 99% problems already

@BrunnerLivio
Copy link
Member

@kamilmysliwiec yes I think so too. Yarn workspaces would be cleaner, because how it handles its dependencies, but it is fine as long there is no urgent need for it.

@kamilmysliwiec
Copy link
Member Author

Fully agree @BrunnerLivio

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
@kamilmysliwiec kamilmysliwiec deleted the build/refactor branch January 24, 2020 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants