-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: refactor packages structure, remove bundle #1176
Conversation
Pull Request Test Coverage Report for Build 1149
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,69 +0,0 @@ | |||
import { expect } from 'chai'; | |||
import { CACHE_MODULE_OPTIONS } from '../../cache/cache.constants'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do tests needed to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was something wrong with it (probably cache
dir name heh)
I think that it should be enough since it solves 99% problems already |
@kamilmysliwiec yes I think so too. Yarn workspaces would be cleaner, because how it handles its dependencies, but it is fine as long there is no urgent need for it. |
Fully agree @BrunnerLivio |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
An alternative proposal to #1060
bundle
directory no longer existsnpm run build
builds all packages and puts output files near tots
filesnpm run prepare
fixednpm run build:lib
builds all packages and put them into node_modules/sample/integration dirsnpm run build
npm run clean
removes alld.ts
and.js
files frompackages
.ts
).d.ts
and.js
)Does this PR introduce a breaking change?
Other information