Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(microservices): update isTerminated during close #2708

Merged
merged 1 commit into from
Aug 24, 2019
Merged

bugfix(microservices): update isTerminated during close #2708

merged 1 commit into from
Aug 24, 2019

Conversation

bigzoo
Copy link
Contributor

@bigzoo bigzoo commented Aug 6, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1364

What is the new behavior?

  • isTerminated value is updated during close

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

update isTerminated during close

Fixes #1364
@bigzoo
Copy link
Contributor Author

bigzoo commented Aug 6, 2019

Haven't added any tests yet since either the file doesn't have unit tests or I couldn't find them. If they are somewhere I wouldn't mind pointers...

@bigzoo
Copy link
Contributor Author

bigzoo commented Aug 6, 2019

Tests failing on PR seem to also be failing in on master
Tests now passing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3957

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.236%

Totals Coverage Status
Change from base Build 3946: 0.0%
Covered Lines: 3638
Relevant Lines: 3820

💛 - Coveralls

@bigzoo
Copy link
Contributor Author

bigzoo commented Aug 8, 2019

cc @kamilmysliwiec

@kamilmysliwiec
Copy link
Member

Thanks @bigzoo!

@kamilmysliwiec kamilmysliwiec added this to the 6.6.0 milestone Aug 24, 2019
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.6.0 August 24, 2019 09:14
@kamilmysliwiec kamilmysliwiec merged commit 9803e4e into nestjs:6.6.0 Aug 24, 2019
@bigzoo bigzoo deleted the fix-terminate-app-after-close branch August 24, 2019 19:25
@lock
Copy link

lock bot commented Nov 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants