Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(common) move createResponseBody to HttpException #2796

Merged
merged 1 commit into from
Aug 24, 2019
Merged

feature(common) move createResponseBody to HttpException #2796

merged 1 commit into from
Aug 24, 2019

Conversation

iveselin
Copy link

renamed and moved createResponseBody function to be exported as a part
of HttpException

Closes #2727

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2727

What is the new behavior?

Easier creation of custom http exceptions with body that is uniform with built in exceptions

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

renamed and moved createResponseBody function to be exported as a part
of HttpException

Closes #2727
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4165

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 95.229%

Totals Coverage Status
Change from base Build 4098: -0.006%
Covered Lines: 3633
Relevant Lines: 3815

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 6.6.0 milestone Aug 24, 2019
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.6.0 August 24, 2019 15:18
@kamilmysliwiec kamilmysliwiec merged commit 6e686bc into nestjs:6.6.0 Aug 24, 2019
@iveselin iveselin deleted the feature/createResponseBodyExport branch August 25, 2019 11:18
@lock
Copy link

lock bot commented Nov 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants