-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(microservices): pass all arguments to request-scoped proxies #2805
Conversation
fix(deps): update dependency mongodb to v3.3.1
fix(deps): update dependency graphql to v14.5.1
Pull Request Test Coverage Report for Build 4243
💛 - Coveralls |
Some microservices, such as gRPC, have more than one arguments in their handler. Previously only the first argument, namely data itself, was passed to the request-scoped proxies, stopping other arguments from propagating. Related to #2802
The previous test case has a false positive. In "createRequestScopedHandler when 'loadPerContext' throws" branch, the exception is not triggered by "loadPerContext", but triggered by undefined "coreModuleRef" in private method "registerRequestProvider". Without attempting to fix two things in one PR, I stubbed the registerRequestProvider and left it untested, only covering what I intended to fix. |
Thanks! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Some microservices, such as gRPC, have more than one arguments in their
handler. Previously only the first argument, namely data itself, was passed
to the request-scoped proxies, stopping other arguments from propagating.
related to #2802
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2802
What is the new behavior?
All arguments are passed into interceptors, pipes, etc.
Does this PR introduce a breaking change?
Other information