feature: log TypeORM error stack when connection fails #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the same error message is displayed regardless of the underlying
cause of failure . This change also outputs the Error.stack string to the
logger.
Fixes #30
PR Checklist
Please check if your PR fulfills the following requirements:
(no tests in this project)
(no specific docs in this project
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When attempting to connect using the
handleRetry
operator, all error information from TypeORM is swallowed and a generic "Unable to connect to the database" message is displayed.Any number of things can cause the TypeORM
createConnection
function to fail - invalid credentials, incorrectly defined entities, database unreachable etc. Without this information the developer is left guessing.Issue Number: #30
What is the new behavior?
The stack trace of the error object is also passed to the logger (rather than an empty string). This gives enough information to the developer to know what the particular failure was.
Does this PR introduce a breaking change?