Error comparison operator since 4.3.0

[njournaud]

Hello,

When i'm using the new release version to get with ?filter=name||$eq||test
I got this error :
Error: Invalid comparison operator. eq,ne,gt,lt,gte,lte,starts,ends,cont,excl,in,notin,isnull,notnull,between expected
at validateComparisonOperator (project\node_modules@nestjsx\crud\node_modules@nestjsx\crud-request\src\request-query.validator.ts:63:11)
When I'm using the previous operator 'eq' the filter do nothing
Thank you

[michaelyali]

@njournaud have you used 4.3.3?

[njournaud]

Oh No I didn't see the new release I was in 4.3.0 thx!

[njournaud]

After testing with 4.3.3 I don't have the error for $eq but the filter still not working.

[michaelyali]

@njournaud what error do you have now after 4.3.3?

[njournaud]

None just the filter not filtering.
I have the alwaysPaginate true for information

[michaelyali]

@njournaud could you please give some examples?

[njournaud]

I put a project in Database with
{ name: project1 }
When I call '/projects?filter=name||$eq||project2' it should not return my previous entity
I got :
{ "data": [ { "name": "project1" } ], "count": 1, "total": 1, "page": 1, "pageCount": 1 }

[michaelyali]

It's very strange. Could you please debug more and provide generated SQL maybe?

[njournaud]

SQL : query: SELECT "Project"."code" AS "Project_code", "Project"."name" AS "Project_name" FROM "public"."project" "Project" LIMIT 25 query: SELECT COUNT(DISTINCT("Project"."code")) as "cnt" FROM "public"."project" "Project"

So no filter
console.log(req.parsed.filter): [ { field: 'name', operator: '$eq', value: 'project2' } ]

[michaelyali]

Could you please send me what does req.parsed.search show?

[njournaud]

Hi,
console.log(JSON.stringify(req.parsed.search)) : {"$and":[null,{},{"code":{"$eq":"project2"}}]}

[njournaud]

I have this in my package.json :

"@nestjsx/crud": "4.3.3",
"@nestjsx/crud-typeorm": "4.3.3",
"@nestjsx/crud-request": "4.3.3",

[njournaud]

My controller and getManyBase :

@Crud({
  model: {
    type: Project,
  },
  dto: {
    create: ProjectDTO,
  },
  params: {
    id: {
      field: 'code',
      type: 'string',
      primary: true,
    },
  },
  routes: {
    exclude: [ 'createManyBase', 'updateOneBase', 'replaceOneBase' ],
    only: [ 'getOneBase', 'getManyBase', 'createOneBase', 'deleteOneBase' ],
    createOneBase: {
      returnShallow: true,
    },
  },
  query: {
    alwaysPaginate: true,
  },
})
@ApiUseTags('Projects')
@ApiBearerAuth()
@Controller()
@UseGuards(AuthGuard)
export class ProjectController implements CrudController<Project> {
  constructor(public service: ProjectService) { }

  get base(): CrudController<Project> {
    return this;
  }
@Override('getManyBase')
  @ApiResponseModelProperty({ type: GetManyResponseForProjectDTO })
  @ApiOkResponse({ type: GetManyResponseForProjectDTO })
  async getMany(@ParsedRequest() req: CrudRequest) {
    console.log(JSON.stringify(req.parsed.search));
    const projects = await this.base.getManyBase(req);

    if (!Array.isArray(projects)) {
      return {
        data: ProjectFactory.entitiesToDtos(projects.data),
        count: projects.count,
        total: projects.total,
        page: projects.page,
        pageCount: projects.pageCount,
      };
    }

    return ProjectFactory.entitiesToDtos(projects);
  }
}

[michaelyali]

and what does console.log(JSON.stringify(req.parsed.search)); show on getManyBase?
and what's your URL for this method looks like?

[njournaud]

console.log(JSON.stringify(req.parsed.search));
{"$and":[null,{},{"name":{"$eq":"test"}}]}

the URL looks like this : http://localhost:3002/projects?filter=name||$eq||test