Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Apps to call services when app shuts down in Dispose(Async)() and OnComplete of HA events #1140

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Jul 10, 2024

Breaking change

Proposed change

Make sure AppScopedHaContextProvider allow Service calls until the end of its DisposeAsync(), so that apps can still us until their eventqueue is cleared and pending background tasks have completed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 87.05882% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81%. Comparing base (0315ea1) to head (9a642d8).

Files Patch % Lines
...l/NetDeamon.HassModel/Internal/QueuedObservable.cs 84% 8 Missing and 2 partials ⚠️
...n.HassModel/Internal/AppScopedHaContextProvider.cs 93% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1140   +/-   ##
====================================
- Coverage    81%     81%   -1%     
====================================
  Files       190     190           
  Lines      3890    3933   +43     
  Branches    478     477    -1     
====================================
+ Hits       3189    3222   +33     
- Misses      517     526    +9     
- Partials    184     185    +1     
Flag Coverage Δ
unittests 81% <87%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done with this man! I will make a alpha release and test it out before we do a release!!

@helto4real helto4real merged commit b7ef9d9 into net-daemon:main Jul 11, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants