Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the registry cache is not refreshed more than once every 5 minutes #1142

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Jul 11, 2024

Breaking change

Proposed change

Make sure the registry cache is not refreshed more than once every 5 minutes, people notices a lot of messages for registry updates in the logs, so apparently on some systems they are somehow triggered automatically. We do keep the log level debug for this message.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82%. Comparing base (a405913) to head (64e9665).

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1142   +/-   ##
====================================
  Coverage    81%     82%           
====================================
  Files       190     190           
  Lines      3933    3961   +28     
  Branches    477     477           
====================================
+ Hits       3217    3255   +38     
+ Misses      531     523    -8     
+ Partials    185     183    -2     
Flag Coverage Δ
unittests 82% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankBakkerNl FrankBakkerNl changed the title Throttle the updating of the registry cache Make sure the registry cache is not refreshed more than once every 5 minutes Jul 12, 2024
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 5 minutes and keeping the debug log-level is fine and seem like a fair time to wait for new labels to get through for example.

@helto4real helto4real merged commit a3fe2fb into net-daemon:main Jul 12, 2024
7 checks passed
@FrankBakkerNl FrankBakkerNl deleted the Throttle_registrycache branch August 5, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants