Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disable Admin API using setting #178

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Fix disable Admin API using setting #178

merged 2 commits into from
Jul 23, 2020

Conversation

helto4real
Copy link
Collaborator

Breaking change

Proposed change

  • Disable API by using NetDaemon.Admin = false or NETDAEMON__ADMIN=false env.
  • Able to change port with normal ASPNETCORE_URLS environment var. (Not recommended)

Type of change

  • Dependency upgrade
  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

ludeeus
ludeeus reviewed Jul 23, 2020
View reviewed changes
src/DaemonRunner/DaemonRunner/NetDaemonExtensions.cs
}).ConfigureWebHostDefaults(webbuilder =>
{
webbuilder.UseKestrel(options =>
{
options.Listen(IPAddress.Loopback, 5000); //HTTP port
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this got moved to?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is default 5000 and we can use the DOTNET_URLS standard to change if we want to but we dont

@helto4real helto4real merged commit aaaa6bd into dev Jul 23, 2020
@helto4real helto4real deleted the disable_api_default branch July 23, 2020 19:52
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@helto4real
Fix disable Admin API using setting (net-daemon#178)
7644a5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludeeus ludeeus ludeeus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web api hardcoded to port 5000
2 participants
@helto4real @ludeeus