Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V1 API #313

Merged
merged 5 commits into from
Feb 6, 2021
Merged

Remove V1 API #313

merged 5 commits into from
Feb 6, 2021

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Feb 6, 2021

Breaking change

From this release there will not be possible to run the V1 API, apps that inherits from NetDaemonApp and fluent API.

Proposed change

Now it is finally the time to clean the code from the V1 API. This API has been deprecated for a long time. The code is removed so the product will be easier to keep beig maintained. Further maintainability refactorings will be in future PR:s but will try not to introduce breaking changes to end-user.

A special version of addon is provided that contains the last release that contains V1 support for your convenience. We recommend upgrading your apps as soon as possible. This special release will be removed at a later time. For docker users please use version 20.05.0 as the last release supporting V1 API:s.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real marked this pull request as ready for review February 6, 2021 13:45
@helto4real helto4real merged commit d9f1f28 into dev Feb 6, 2021
@helto4real helto4real deleted the remove_v1_api branch February 6, 2021 14:38
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* Remove V1 API

* More cleanup

* Added example of docker-compose file

* Remove  unused HomeAssistantStateChangedAttribute

* Remove dead code and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant