Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webhook support #369

Merged
merged 1 commit into from
May 16, 2021
Merged

Added webhook support #369

merged 1 commit into from
May 16, 2021

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented May 15, 2021

Breaking change

Proposed change

Make a trigger template webhook sensor in HA plus some cleanup

template:
  - trigger:
      - platform: webhook
        webhook_id: my-super-secret-id
    sensor:
      - name: "NetDaemon webhook temp sensor"
        state: "{{ trigger.json.temperature }}"
        unit_of_measurement: °C

Use following code to trigger it:

public record TriggerData
{
   [JsonPropertyName("temperature")]
   public double Temperature { get; set; }
}

var data = new TriggerData {Temperature=4.3};
// trigger using record
await client.TriggerWebhook("my-super-secret-id", data);
// trigger using anon type
await client.TriggerWebhook("my-super-secret-id", new {temperature = 4.1});

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real merged commit c5d8688 into dev May 16, 2021
@helto4real helto4real deleted the webhook-support branch May 16, 2021 07:41
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants