Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generic RxAppMock #433

Merged
merged 2 commits into from
Aug 28, 2021
Merged

add generic RxAppMock #433

merged 2 commits into from
Aug 28, 2021

Conversation

makp0
Copy link
Contributor

@makp0 makp0 commented Aug 18, 2021

Breaking change

Proposed change

Make RxAppMock generic to allow testing against interfaces inherited from INetDaemonRxApp

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This PR doesn't modify the original RxAppMock. Just makes it generic

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix the errors and warnings in the CI and all is golden. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #433 (5e54c7c) into dev (491324c) will decrease coverage by 0.20%.
The diff coverage is 80.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #433      +/-   ##
==========================================
- Coverage   54.57%   54.37%   -0.21%     
==========================================
  Files          82       83       +1     
  Lines        4621     4616       -5     
  Branches      714      714              
==========================================
- Hits         2522     2510      -12     
- Misses       1871     1874       +3     
- Partials      228      232       +4     
Flag Coverage Δ
unittests 54.37% <80.35%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Fakes/NetDaemon.Fakes/RxAppMock[T].cs 79.79% <79.79%> (ø)
src/App/NetDaemon.App/Common/ExtensionMethods.cs 80.76% <100.00%> (+1.17%) ⬆️
src/Fakes/NetDaemon.Fakes/ReactiveEventMock.cs 100.00% <100.00%> (ø)
...pp/NetDaemon.App/Common/Reactive/NetDaemonRxApp.cs 82.55% <0.00%> (-1.71%) ⬇️
...rc/Daemon/NetDaemon.Daemon/Daemon/NetDaemonHost.cs 53.36% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491324c...5e54c7c. Read the comment docs.

@helto4real helto4real merged commit 54b59a1 into net-daemon:dev Aug 28, 2021
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* add generic RxAppMock

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants