Redesign of startup and reconnect logic #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
* Redesign of startup and reconnect logic * Fixed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Redesigned how NetDaemon behaves with Disconnections.
Before: Internally tried to reconenct
Now: Reconnection logic is pushed to the service. This means that with a disconnect from Home assistant the NetDaemon will be reloaded entirenly and everything is in start-up state
Type of change
Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests
This PR fixes or closes issue: fixes The app switches are not re-added when Home Assistant is restarted #93
This PR is related to issue:
Link to documentation pull request:
Checklist
If user exposed functionality or configuration variables are added/changed: