Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 version 4 release #958

Merged
merged 24 commits into from
Oct 29, 2023
Merged

.NET 8 version 4 release #958

merged 24 commits into from
Oct 29, 2023

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Oct 21, 2023

Breaking change

  • New .NET dependency (.NET 8)
  • Source deploy requires additional nuget package
  • New version 4 docker containers netdaemon4

Proposed change

Following changes are planned, boxes will be checked when done:

  • Upgrade all projects to .NET 8 and C# 12
  • Make CI action to allow making pre-releases of nuget packages
  • Change naming of Nuget packages to start with NetDaemon (Namespace changes need to be discussed). This is so we can claim ownership over NetDaemon id.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (80d8bf8) 78.90% compared to head (25460d7) 77.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #958      +/-   ##
==========================================
- Coverage   78.90%   77.38%   -1.53%     
==========================================
  Files         175      176       +1     
  Lines        3504     3507       +3     
  Branches      447      446       -1     
==========================================
- Hits         2765     2714      -51     
- Misses        555      609      +54     
  Partials      184      184              
Flag Coverage Δ
unittests 77.38% <87.03%> (-1.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...yedApps/Compiler/CollectableAssemblyLoadContext.cs 100.00% <ø> (ø)
...del.SourceDeployedApps/Compiler/CompileSettings.cs 50.00% <ø> (ø)
...n.AppModel.SourceDeployedApps/Compiler/Compiler.cs 98.46% <100.00%> (ø)
....SourceDeployedApps/Compiler/SyntaxTreeResolver.cs 100.00% <ø> (ø)
...oyedApps/DynamicallyCompiledAppAssemblyProvider.cs 64.28% <ø> (ø)
...el/Common/Extensions/ServiceCollectionExtension.cs 94.73% <100.00%> (+3.07%) ⬆️
...nternal/Config/Yaml/YamlConfigurationFileParser.cs 89.13% <100.00%> (-0.24%) ⬇️
...on.AppModel/Internal/Context/ApplicationContext.cs 95.83% <100.00%> (ø)
...Common/Exceptions/HomeAssistantApiCallException.cs 40.00% <ø> (ø)
...assClient/Internal/Helpers/ResultMessageHandler.cs 96.77% <100.00%> (+0.10%) ⬆️
... and 13 more

... and 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<PackageId>JoySoftware.NetDaemon.Extensions.Mqtt</PackageId>
<Version>22.5.1</Version>
<PackageId>NetDaemon.Extensions.Mqtt</PackageId>
<Version>23.42.0</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this updated? I think it is only used for local builds. We could put 1.0.0 here to make it clear it is a local build

@helto4real helto4real temporarily deployed to CI - release environment October 22, 2023 15:42 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 22, 2023 15:46 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 23, 2023 14:56 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 23, 2023 14:56 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 23, 2023 18:10 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 23, 2023 18:10 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 05:06 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 05:08 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 05:08 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 09:43 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 09:43 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 12:49 — with GitHub Actions Inactive
@helto4real helto4real temporarily deployed to CI - release environment October 28, 2023 12:49 — with GitHub Actions Inactive
… file (#978)

* Move common defaults to directory build props

* update path in dockerfile

* add missing build triggers

* update the other dockerfile as well
@helto4real helto4real had a problem deploying to CI - analyze environment October 28, 2023 14:02 — with GitHub Actions Failure
* Primary ctrs and some warnings fixed

* Adding timeout
@helto4real helto4real had a problem deploying to CI - analyze environment October 29, 2023 08:42 — with GitHub Actions Failure
@helto4real helto4real marked this pull request as ready for review October 29, 2023 08:43
@helto4real helto4real merged commit 5bcf6fc into dev Oct 29, 2023
6 of 10 checks passed
@helto4real helto4real deleted the dotnet8 branch October 29, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants