[Codegen] Allow any nullable double fields to be strings or doubles and improved error reporting #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helto4real
approved these changes
Nov 3, 2023
| if (parseErrors.Count == 0) return; | ||
|
|
||
| Console.ForegroundColor = ConsoleColor.Yellow; | ||
| Console.WriteLine(""" |
There was a problem hiding this comment.
yea this is so much nicer error message!
helto4real
pushed a commit
that referenced
this pull request
Nov 3, 2023
…nd improved error reporting (#984) * Allow any nullable double fields to be strings or doubles and improved error reporting * small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
[Codegen] Allow any nullable double fields to be strings or doubles and improved error reporting
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: