Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen] Allow any nullable double fields to be strings or doubles and improved error reporting #984

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

FrankBakkerNl
Copy link
Contributor

Proposed change

[Codegen] Allow any nullable double fields to be strings or doubles and improved error reporting

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and fast fix! This time I tested it on my setup in the debugger too and it worked nicely!

if (parseErrors.Count == 0) return;

Console.ForegroundColor = ConsoleColor.Yellow;
Console.WriteLine("""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is so much nicer error message!

@helto4real helto4real merged commit dfd1684 into net-daemon:bugfix Nov 3, 2023
2 checks passed
helto4real pushed a commit that referenced this pull request Nov 3, 2023
…nd improved error reporting (#984)

* Allow any nullable double fields to be strings or doubles and improved error reporting

* small fix
@FrankBakkerNl FrankBakkerNl deleted the fix/codegen_step_any branch November 18, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants