Use keepalive_interval option as IO select timeout #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@delano any chance you could take a look at this? |
| @@ -441,6 +441,17 @@ def process(wait=nil, &block) | |||
| end | |||
| end | |||
|
|
|||
| def io_select_wait(wait) | |||
| return wait if wait | |||
There was a problem hiding this comment.
could write as wait || keepalive_intreval actually we should wait for the smaller of two, shouldn't we?
There was a problem hiding this comment.
I based this on the implementation in net-ssh, where the wait argument takes precedence over the keepalive interval: https://github.com/net-ssh/net-ssh/blob/v3.0.2/lib/net/ssh/connection/session.rb#L611-L615
I agree though, using the smaller of the two values seems more correct to me. I'll fix it here, and submit a pull request to net-ssh to change the behaviour there too.
There was a problem hiding this comment.
good catch needs to be fixed in net-ssh as well
Net::SSH supports sending keepalive packets to the server to check whether the connection is still alive. For this to work, IO#select needs to be given a timeout so that the event loop can run periodically and send the packets.
eugeneius
force-pushed
the
keepalive_timeout
branch
from
5f98162 to
1da352d
Compare
mfazekas
added a commit
that referenced
this pull request
Mar 12, 2016
Use keepalive_interval option as IO select timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::SSH supports sending keepalive packets to the server to check whether the connection is still alive. For this to work,
IO#selectneeds to be given a timeout so that the event loop can run periodically and send the packets.