Remove base64 runtime dependency #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
fix-base64-warning
branch
from
5526799
to
7c05781
Compare
Starting in Ruby 3.3.0, `require "base64"` triggers a warning: > base64 was loaded from the standard library, but will no longer be > part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile > or gemspec. Rather than introduce a new dependency, this commit removes the base64 requirement in favor of using `String#pack` and `String#unpack1` directly. (The base64 gem is just a thin wrapper around these methods.) I left base64 as a development dependency so that the existing tests could continue to use `Base64`, to confirm there are no regressions due to my changes.
mattbrictson
force-pushed
the
fix-base64-warning
branch
from
7c05781
to
a98673a
Compare
mfazekas
approved these changes
Dec 26, 2023
|
@mattbrictson thanks much, this look good! |
|
@mattbrictson I've released this as https://rubygems.org/gems/net-ssh/versions/7.2.2.rc1 |
|
@mfazekas testing against 7.2.2.rc1, and unfortunately I still see the warning:
It looks like this PR was incomplete: I forgot to remove the |
mattbrictson
added a commit
to mattbrictson/net-ssh
that referenced
this pull request
Jan 7, 2024
The previous PR net-ssh#932 refactored the code to no longer use the Base64 module, but forgot to remove the actual `require "base64"` statements. This follow up commit removes those requires to fix the following warning on Ruby 3.3: > net/ssh/known_hosts.rb:3: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of net-ssh-7.2.2.rc1 to add base64 into its gemspec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Ruby 3.3.0,
require "base64"triggers a warning:Rather than introduce a new dependency, this commit removes the base64 requirement in favor of using
String#packandString#unpack1directly. (The base64 gem is just a thin wrapper around these methods.)I left base64 as a development dependency so that the existing tests could continue to use
Base64, to confirm there are no regressions due to my changes.The approach in this PR is similar to that used in several other gems, including:
base64gem from runtime dependency rubocop/rubocop#12313