[Bug]: Unable to assign primary mac address when identical mac address exists

[RobinR1]

Ansible NetBox Collection version

v3.21.0

Ansible version

core version: 2.16.14

NetBox version

v4.2.6

Python version

3.11

Steps to Reproduce

Create a host with a physical and a virtual interface
Create the same MAC address on both virtual interfaces:
Assign the MAC address as primary on both virtual interfaces. This should be possible as it are actually 2 separate mac_address objects, each assigned to a different interface:

- name: Create MAC addresses
  delegate_to: localhost
  netbox.netbox.netbox_mac_address:
    netbox_url: "{{ netbox_url }}"
    netbox_token: "{{ netbox_token }}"
    data: 
      assigned_object:
        device: Test host
        name: "{{ item }}"
      mac_address: AA:BB:CC:DD:EE:FF
    query_params:
      - assigned_object
      - name
  loop:
    - Gig-E1
    - virtual1
  register: netbox_mac_address_result

- name: Set NIC's Primary MAC addresses
  delegate_to: localhost
  netbox.netbox.netbox_device_interface:
    netbox_url: "{{ netbox_url }}"
    netbox_token: "{{ netbox_token }}"
    data:
      device: Test host
      name: "{{ item.item }}"
      primary_mac_address: AA:BB:CC:DD:EE:FF
loop: "{{ netbox_mac_address_result.results }}"

Expected Behavior

MAC address object assigned to interface Gig-E1 on host Test host is set as primary_mac_address on interface Gig-E1
MAC address object assigned to interface virtual1 on host Test host is set as primary_mac_address on interface virtual1

Observed Behavior

Attempt to assign MAC address as primary mac adress of an interface results in the error:

msg: More than one result returned for primary_mac_address 

Despite the fact that there is only one unique mac address defined on each interface. It only happens to be the same mac_address string for eacht of those interfaces.

I have tried passing the mac address object id as primary_mac_address:

- name: Set NIC's Primary MAC addresses
  delegate_to: localhost
  netbox.netbox.netbox_device_interface:
    netbox_url: "{{ netbox_url }}"
    netbox_token: "{{ netbox_token }}"
    data:
      device: Test host
      name: "{{ item.item }}"
      primary_mac_address: 
        id: "{{ item.mac_address.id "}}
loop: "{{ netbox_mac_address_result.results }}"

But this results in the error:

msg: 'Could not resolve id of primary_mac_address: {''id'': ''1147''}'

Passing the full mac_address object as primary_mac_address yields the same error.

It seems that the primary_mac_address parameter only accepts an actual MAC address string but then searches for it without considering the assigned_object being the same as the device_interface where we try to set the primary_mac_address for.

[philfry]

I hit this bug, too.
We have a couple of hosts with the same mac address at different sites, but I cannot add the mac address to Netbox.

Neither

- netbox.netbox.netbox_mac_address:
    data:
      mac_address: 'aa:bb:cc:dd:ee:ff'
      assigned_object:
        device: myhostname
        name: eth47

nor

- netbox.netbox.netbox_device_interface:
    data:
      device: myhostname
      name: eth47
      primary_mac_address: 'aa:bb:cc:dd:ee:ff'

works, I always get:

"msg": "More than one result returned for AA:BB:CC:DD:EE:FF"}

[k0ste]

The release of API MAC addresses in NetBox is disgusting. I don't understand why MAC addresses weren't made with the same fields as IP addresses - site, tenant, etc...

[karlism]

We've been hit by this issue too, it appears that netbox.netbox.netbox_device_interface modules mac_address parameter has no effect whatsoever anymore and primary_mac_address can only work if the MAC address is unique despite the fact that NetBox web UI allows adding same MAC address multiple times. Having duplicate MACs even on single host is quite common (VLANs, teaming/bonding etc.).

$ cat netbox_test.yml                      
---
- hosts: "{{ target|d('localhost') }}"
  gather_facts: "{{ facts | d(False) }}"

  vars:
    _netbox_url: "https://netbox.example.com/"
    _netbox_token: "xxx"

  tasks:
    - name: "add mac address"
      netbox.netbox.netbox_mac_address:
        netbox_url: "{{ _netbox_url }}"
        netbox_token: "{{ _netbox_token }}"
        data:
          mac_address: "AA:BB:CC:DD:EE:FF"
          assigned_object:
            device: "testvm1"
            name: "ens222"
        query_params:
          - assigned_object
          - name
      delegate_to: localhost

    - name: "add mac address"
      netbox.netbox.netbox_mac_address:
        netbox_url: "{{ _netbox_url }}"
        netbox_token: "{{ _netbox_token }}"
        data:
          mac_address: "AA:BB:CC:DD:EE:FF"
          assigned_object:
            device: "testvm1"
            name: "ens223"
        query_params:
          - assigned_object
          - name
      delegate_to: localhost

    - name: "add network interfaces to NetBox device"
      netbox.netbox.netbox_device_interface:
        netbox_url: "{{ _netbox_url }}"
        netbox_token: "{{ _netbox_token }}"
        data:
          device: "testvm1"
          type: "virtual"
          name: "ens223"
          enabled: true
          primary_mac_address: "AA:BB:CC:DD:EE:FF"
      delegate_to: localhost


$ ansible-playbook netbox_test.yml

PLAY [localhost] ************************************************************************************************************************************

TASK [add mac address] ******************************************************************************************************************************
ok: [localhost]

TASK [add mac address] ******************************************************************************************************************************
ok: [localhost]

TASK [add network interfaces to NetBox device] ******************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "More than one result returned for primary_mac_address"}

PLAY RECAP ******************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0