Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 958: Location filter #963

Merged
merged 2 commits into from Mar 30, 2023
Merged

Conversation

rodvand
Copy link
Contributor

@rodvand rodvand commented Mar 30, 2023

Fix #958

Add site as a possible filter when creating a location. You can now create a location named the same in two different sites.

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@sc68cal
Copy link
Contributor

sc68cal commented Mar 30, 2023

Can we add a set of tests for regression purposes

@rodvand rodvand merged commit d4ca979 into netbox-community:devel Mar 30, 2023
7 checks passed
@rodvand rodvand deleted the 958_location branch March 30, 2023 20:46
rodvand added a commit to rodvand/ansible_modules that referenced this pull request May 1, 2023
* Fix filter when trying to create a location named the same in different sites
* Add regression test for issue 958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nebox_location module updates existing locations instead of creating new ones in a different site
2 participants