Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'asset_tag' in the rack view #12518

Closed
PieterL75 opened this issue May 8, 2023 · 7 comments
Closed

Show 'asset_tag' in the rack view #12518

PieterL75 opened this issue May 8, 2023 · 7 comments
Labels
pending closure Requires immediate attention to avoid being closed for inactivity status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application

Comments

@PieterL75
Copy link
Contributor

NetBox version

v3.4.10

Feature type

Data model extension

Proposed functionality

Add 'Asset tag' to the dropdown of the 'rack view'
image

Use case

In our datacenter, we only have the assettags labeled on the devices, not the hostnames.
Currently we can see the assettag if we 'hover' over the name of the device, but it would be better to see the asset in the view direct

Database changes

No response

External dependencies

No response

@PieterL75 PieterL75 added the type: feature Introduction of new functionality to the application label May 8, 2023
@PieterL75
Copy link
Contributor Author

PieterL75 commented May 12, 2023

I have a Branch ready that will implement this feature.
https://github.com/PieterL75/netbox/tree/issue12518_addassettagtorackview
can I create a PR for review ?

PieterL75 pushed a commit to PieterL75/netbox that referenced this issue May 12, 2023
@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label May 12, 2023
@jeremystretch
Copy link
Member

This probably isn't something we can support without the introduction of a customization mechanism for the device label. It wouldn't make sense to add "asset tags" as an alternative directly to the images/labels dropdown.

@PieterL75
Copy link
Contributor Author

The Assettag is the unique physical identifier of an Asset. The little sticker (actually a pretty big one on front and back) that we put on the device, to identify it in the datacenter, without the burden of (changing) naming standards.
Having a RackView with Assettag is pretty logical to me..

The PR I have takes care of that, and provides 2 means of creating that view

  • with the dropdown
  • with an extra parameter "use_assettag=true" to the vsg generating url

That allows us to get that view in automation and in the gui

Pieter

@PieterL75 PieterL75 changed the title Add 'asset tag' to rack view Show 'asset_tag' in the rack view May 22, 2023
@PieterL75
Copy link
Contributor Author

@jeremystretch Shall I submit the PR ? then you can review how it works.
This FR will only add an extra view pane to the racks, nothing more.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Aug 29, 2023
@github-actions
Copy link
Contributor

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
@PieterL75
Copy link
Contributor Author

Can this be reviewed again ?
I would very much like to see that 'asset_tag' as labels in the view, rather than the 'devicename'
In our datacenters, the physical world works only with 'asset tags' and not with devicenames.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending closure Requires immediate attention to avoid being closed for inactivity status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants