Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Required fields that probably shouldn't be #16078

Closed
joskin-nimar opened this issue May 10, 2024 · 0 comments · Fixed by #16115
Closed

GraphQL: Required fields that probably shouldn't be #16078

joskin-nimar opened this issue May 10, 2024 · 0 comments · Fixed by #16115
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available severity: medium Results in substantial degraded or broken functionality for specfic workflows topic: GraphQL type: bug A confirmed report of unexpected behavior in the application

Comments

@joskin-nimar
Copy link

joskin-nimar commented May 10, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0.1

Python Version

3.11

Steps to Reproduce

  1. Go to GraphQL console
  2. Enter this query
query {
  ip_address_list(filters: {tenant: "my-tenant"}){
    address
  }
}
  1. You'll have an error that some required fields are missing

Expected Behavior

The family, mask_length__gte and mask_length__lte filters shouldn't be mandatory.

Probably the same for other filters.
Also broken on https://demo.netbox.dev/

Observed Behavior

{
  "data": null,
  "errors": [
    {
      "message": "Field 'IPAddressFilter.family' of required type 'Int!' was not provided.",
      "locations": [
        {
          "line": 2,
          "column": 28
        }
      ]
    },
    {
      "message": "Field 'IPAddressFilter.mask_length__gte' of required type 'Int!' was not provided.",
      "locations": [
        {
          "line": 2,
          "column": 28
        }
      ]
    },
    {
      "message": "Field 'IPAddressFilter.mask_length__lte' of required type 'Int!' was not provided.",
      "locations": [
        {
          "line": 2,
          "column": 28
        }
      ]
    }
  ]
}
@joskin-nimar joskin-nimar added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 10, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 10, 2024
@jeremystretch jeremystretch added topic: GraphQL severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 13, 2024
@arthanson arthanson self-assigned this May 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available severity: medium Results in substantial degraded or broken functionality for specfic workflows topic: GraphQL type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants