Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9071 add header to plugin menu #10441

Merged
merged 8 commits into from
Sep 28, 2022
Merged

9071 add header to plugin menu #10441

merged 8 commits into from
Sep 28, 2022

Conversation

arthanson
Copy link
Collaborator

Fixes: #9071

Allows plugins to define a menu_heading (see below) that will make it a top-level menu. This still needs to edit the doc files for plugins. @jeremystretch the original issue had a request to allow items to be appended to existing menus, however this would require the menu.groups to be an array instead of an immutable tuple so items could be appended on - not sure if this is desired or not?

menu_heading = {
"title": "MyPlugin",
"icon": "mdi-puzzle"
}

@arthanson arthanson changed the base branch from develop to feature September 23, 2022 19:38
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Sep 26, 2022
@arthanson arthanson changed the title 9071 add header to plugin menu DRAFT: 9071 add header to plugin menu Sep 26, 2022
@arthanson arthanson changed the title DRAFT: 9071 add header to plugin menu 9071 add header to plugin menu Sep 26, 2022
@arthanson arthanson marked this pull request as ready for review September 26, 2022 22:05
netbox/extras/plugins/__init__.py Outdated Show resolved Hide resolved
netbox/extras/plugins/__init__.py Outdated Show resolved Hide resolved
netbox/netbox/navigation_menu.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit c95ad5b into feature Sep 28, 2022
@jeremystretch jeremystretch deleted the 9071-plugin-menu branch September 28, 2022 21:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow plugins to inject top-level navigation menu items
2 participants