-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12795 custom user model #15005
12795 custom user model #15005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! On first pass this seems to work just fine, however I'm extremely cautious of running across an unforeseen landmine. Will continue to do some further experimentation. We also need to figure out what to do with the NetBoxUser content type.
One other nit: We'll need to ensure that the user and group content types are available in |
@jeremystretch updated the registry code and updated the migration to migrate the CustomField from any existing ct pointers to the new one. |
Fixes: #12795
Did custom user model - dumped and compared SQL schemas and they look correct. Any extra testing suggestions welcome.
Did not do groups for several reasons:
Wouldn't be a big thing to convert Groups bug just some potential issues and not a big reason to do it right now IMHO. Also, an option is to potentially do the work for Django and submit a PR - though more work to handle the relation between customizable User and Group models.