Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14653 Add Inventory Item column to all Device components tables #16210

Merged
merged 2 commits into from
May 21, 2024
Merged

14653 Add Inventory Item column to all Device components tables #16210

merged 2 commits into from
May 21, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #14653

Monosnap Power Outlets | NetBox 2024-05-20 14-35-25
Monosnap Power Ports | NetBox 2024-05-20 14-34-21
Monosnap Rear Ports | NetBox 2024-05-20 14-33-23
Monosnap Console Server Ports | NetBox 2024-05-20 14-31-13
Monosnap Console Ports | NetBox 2024-05-20 14-29-18
Monosnap Front Ports | NetBox 2024-05-20 14-27-48

@arthanson arthanson marked this pull request as ready for review May 20, 2024 21:37
jeremystretch
jeremystretch requested changes May 21, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just declare the inventory_items column on ModularDeviceComponentTable, which is used only for these seven component types.

jeremystretch
jeremystretch approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 5b83d70 into develop May 21, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 14653-inventory-item branch May 21, 2024 20:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Inventory Item column in all Device components table
2 participants
@arthanson @jeremystretch