Move the create/update/cancel buttons to the right-hand side and make them float #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’d like to work on #2237. Before I do that, however, I’d like to know what was wrong with this PR. It seems like the code is a little outdated, was that the reason? Or is there anything in particular that needs to be changed? |
|
@hellerve It's been a while now, but I think I became frustrated with the approach I tried after encountering some non-default actions (buttons other than "create" and "create and add another"), and realized a more flexible approach would be necessary. |
|
Alright, I’m going to try and look at it; I’ll keep you posted where this leads me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2237
This approach moves the create/update/cancel buttons when editing an object to the top right corner and keeps them fixed as the page scrolls. This ensures the buttons are always immediately accessible regardless of where the user is focused in the form.