Skip to content

Conversation

mfiedorowicz
Copy link
Member

  • configure diode target and disallow its override via NetBox UI with PLUGINS_CONFIG, e.g.:
PLUGINS_CONFIG = {
    "netbox_diode_plugin": {
        "diode_target": "grpc://localhost:8080/diode", # The Diode gRPC target for communication with Diode server, default: "grpc://localhost:8080/diode"
        "disallow_diode_target_override": True, # Disallow the Diode target to be overridden by the user, default: False
    }
}
  • during initial migration, load secrets for diode related API keys from mounted paths under /run/secrets/*, with a fallback to environment variables and eventually generate keys in-flight
Screenshot 2024-09-23 at 17 58 21 Screenshot 2024-09-23 at 17 58 29

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1433 1419 99% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/tests/test_forms.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/forms.py 100% 🟢
netbox_diode_plugin/tests/test_views.py 100% 🟢
netbox_diode_plugin/views.py 99% 🟢
TOTAL 100% 🟢

updated for commit: 1f33485 by action🐍

Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! LGTM

@mfiedorowicz mfiedorowicz merged commit a5ebe02 into develop Sep 23, 2024
5 checks passed
@mfiedorowicz mfiedorowicz deleted the plugin-config-improvements branch September 23, 2024 19:46
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants