Skip to content

Conversation

mfiedorowicz
Copy link
Member

This pull request updates the netboxlabs/diode/sdk/ingester.py file to enhance the data model for platform and rack reservation creation, as well as improve custom field validation flexibility. The main changes include adding new optional fields to the Platform and RackReservation models and updating the validation parameter types for custom fields.

Platform and RackReservation model enhancements:

  • Added parent and comments fields to the Platform creation method, allowing platforms to reference a parent platform and include comments.
  • Added a status field to the RackReservation creation method, enabling reservation status tracking. [1] [2]

Custom field validation improvements:

  • Changed the types of validation_minimum and validation_maximum in custom field creation from int to float for more flexible validation.

Miscellaneous:

  • Updated the generated code timestamp in the file header.

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Copy link

github-actions bot commented Oct 2, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
/opt/hostedtoolcache/Python/3.10.18/x64/lib/python3.10/site-packages/netboxlabs/diode/sdk
   client.py256598%303, 364, 369, 373, 461
TOTAL290598% 

Tests Skipped Failures Errors Time
109 0 💤 0 ❌ 0 🔥 1.172s ⏱️

@mfiedorowicz mfiedorowicz merged commit fa2cc14 into develop Oct 3, 2025
6 checks passed
@mfiedorowicz mfiedorowicz deleted the feat-netbox-4-4-support branch October 3, 2025 11:53
Copy link

github-actions bot commented Oct 6, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants