Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate GirdersSwift to Swift 5.0 #8

Merged
merged 10 commits into from
Apr 11, 2019
Merged

Migrate GirdersSwift to Swift 5.0 #8

merged 10 commits into from
Apr 11, 2019

Conversation

filipsardjoski
Copy link
Collaborator

No description provided.

@martinmitrevski
Copy link
Contributor

@sardzoski update the .travis.yml with osx_image: xcode10.2, otherwise the build fails and the PR can't be merged in.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 70.575%
Changes Missing Coverage Covered Lines Changed/Added Lines %
GirdersSwift/src/main/swift/http/RequestGenerator.swift 3 6 50.0%
Totals Coverage Status
Change from base Build 74: 0.06%
Covered Lines: 1252
Relevant Lines: 1774
💛 - Coveralls

@martinmitrevski martinmitrevski merged commit c58a6d7 into netceteragroup:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipsardjoski @martinmitrevski @coveralls