Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial value for mu is not consistent with the paper #13

Open
zhangxiangnick opened this issue Jun 10, 2016 · 1 comment
Open

initial value for mu is not consistent with the paper #13

zhangxiangnick opened this issue Jun 10, 2016 · 1 comment

Comments

@zhangxiangnick
Copy link

the parameter "mu" in Candes paper (http://statweb.stanford.edu/~candes/papers/RobustPCA.pdf, see Eqn. 5.1) is actually the inverse of "mu" in Zhou's paper (http://arxiv.org/abs/1001.2363, see Eqn. 15). Therefore, in the anomalydetection.cpp, it should be

double mu = 4_X.lpNorm<1>()/(m_n);

instead of

double mu = m_n / (4_X.lpNorm<1>());

to be consistent with both papers. This also makes sense because in the getDynamicMu(), mu is set to be linear with "sigma", not with inverse of "sigma".

@wuciawe
Copy link

wuciawe commented Aug 2, 2016

Hi, I've got confused with this implementation. It seems that the implementation doesn't follow the Candes paper, why is the E_{k} part missing in updating L, X and E?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants