Skip to content

[NAE-2036] Task-List-View to open Case by link #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

camperko
Copy link
Member

@camperko camperko commented Feb 12, 2025

Description

Implements possibility to navigate to task list view of case which caseId is included in URL. Only tasks of this case are displayed in this task list view. This view needs to be included in nae.json and registered in view.service of project. See example in code.

Implements NAE-2036

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Manually from application

Name Tested on
OS Linux Mint 21
Runtime Node 20.13.1
Dependency Manager npm 10.8.0
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @Kovy95 @martinkranec
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

- add option to open DefaultSimpleTaskView from URL when defined in nae.json and registered in view service
- view in nae.json needs to have :singleCaseId in the path
@@ -42,6 +42,7 @@ import {BreadcrumbsExampleComponent} from './doc/breadcrumbs-example/breadcrumbs
import {DashboardCaseExampleComponent} from './doc/dashboard-case-example/dashboard-case-example.component';
import {ImpersonationDemoComponent} from './doc/impersonation-demo/impersonation-demo.component';
import {ChangePasswordComponent} from "./doc/forms/change-password/change-password.component";
import {DefaultSimpleTaskViewComponent} from 'netgrif-components';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix import

}

public extractCompleteFilterFromData(dataSection: Array<DataGroup>, fieldId: string = UserFilterConstants.FILTER_FIELD_ID): Filter | undefined {
public extractCompleteFilterFromData(activatedRoute: ActivatedRoute, dataSection?: Array<DataGroup>, fieldId: string = UserFilterConstants.FILTER_FIELD_ID): Filter | undefined {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be activatedRoute also the optional ? i dont think we want to put activated route in this function on views that arent supposed to take route parameter

@camperko camperko self-assigned this Feb 13, 2025
@camperko camperko added improvement New feature or request new feature labels Feb 13, 2025
Retoocs
Retoocs previously approved these changes Feb 13, 2025
- fix imports -> netgrif-components-core - @netgrif/components-core
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.4% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@mazarijuraj mazarijuraj merged commit b8c06de into release/6.5.0 Feb 18, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants