-
Notifications
You must be signed in to change notification settings - Fork 4
[NAE-1381] Public view task loading #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add new service: public-task-loading.service.ts - update publicBaseFilterFactory in PublicTaskViewComponent
- add provider
projects/nae-example-app/src/app/doc/public-task-view/public-task-view.component.ts
Outdated
Show resolved
Hide resolved
- add tests and update return expression
projects/nae-example-app/src/app/doc/public-task-view/public-task-view.component.ts
Show resolved
Hide resolved
...s/netgrif-components-core/src/lib/view/task-view/service/public-task-loading.service.spec.ts
Show resolved
Hide resolved
projects/netgrif-components-core/src/lib/view/task-view/service/public-task-loading.service.ts
Outdated
Show resolved
Hide resolved
- incorporate comments from PR
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Kudos, SonarCloud Quality Gate passed! |
Description
Set LoadingEmitter while system creating new case
Fixed NAE-1381
Dependencies
none
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Assisted testing + manual testing + front-end tests
Test Configuration
Checklist: