refactor: remove version package #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removed the version package. Having a version.First does not justify a package by itself. The function is not specific to versions and has been recreated as xstrings.Coalesce(). No need to deprecate as it is only used in one place.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete "version" package by replacing its functionality with the newly introduced xstrings.Coalesce function and cleaning up related references.
- Reimplemented version logic with xstrings.Coalesce in xstrings/funcs.go and added corresponding tests in xstrings/funcs_test.go.
- Removed all files related to the version package (doc.go, compare.go, compare_test.go).
- Updated the README.md to remove the version package from the package listing.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| xstrings/funcs_test.go | Added tests to validate the behavior of Coalesce(). |
| xstrings/funcs.go | Introduced the Coalesce function to replace version.First(). |
| version/doc.go | Removed the version package documentation. |
| version/compare_test.go | Removed the tests for the old version package functionality. |
| version/compare.go | Removed the implementation of version.First(). |
| README.md | Removed the version package listing from the documentation. |
ChBLA
approved these changes
Apr 22, 2025
KimNorgaard
added a commit
that referenced
this pull request
Apr 22, 2025
This removed the version package. Having a version.First does not justify a package by itself. The function is not specific to versions and has been recreated as xstrings.Coalesce(). No need to deprecate as it is only used in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the version package. Having a version.First() does not justify a package by itself, especially seeing that the function is not specific to versions. It has been recreated as xstrings.Coalesce(). No need to deprecate as it is only used in one place.