fix missing .netlify/edge-functions/angular-ssr #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Skn0tt
approved these changes
Apr 19, 2024
|
What's the release cycle for this? Do we need to manually publish to npm or something? |
|
I think so - release-please should do it automatically, but the PR was missing the right title I believe. could you open another PR with an empty commit, and name the PR |
|
Done: #107 |
|
we did it! #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in the forums: https://answers.netlify.com/t/116319/
I was able to reproduce as well. Turns out
@netlify/buildalready clears that directory here: https://github.com/netlify/build/blob/main/packages/build/src/plugins_core/pre_dev_cleanup/index.ts#L18-L42, so this plugin should not have to do anything.