-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add basic support for angular universal #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -47,7 +47,17 @@ | |||
}, | |||
"devDependencies": { | |||
"@netlify/eslint-config-node": "^3.1.7", | |||
"@nguniversal/express-engine": "^12.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a dependency, not dev dep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
um, idk. i wasnt sure if the validateUniversal check only failed for the demo site on the CLI because of the unique setup
4c153a0
to
2f07113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! This is awesome. I'd suggest waiting for @tzmanics to review it though.
e44a592
to
ce2de62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. This is a lot neater. I wonder if there is any value in still allowing them to optionally pass in a projectName, in case they don't want to use the default. I don't really know enough about Angular to know if this is something that people might need.
This is really great! Nice work! I notice that in the readme we say to create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome! great work!!
7f15cb9
to
ce2de62
Compare
@tzmanics what different information are you referring to? the build command is the same, just in an npm script. the extra configs ( |
7d2430d
to
dbf8dad
Compare
This PR adds the minimum level support for an Angular Universal site like the site under /demo (aka the site from Jason's original proof of concept). Right now, it's missing some of the crucial monorepo logic that Matt built into the Next plugin. I think this can be excluded from a beta.
Callouts:
getAngularRoot
logic akin togetNextRoot
in the next plugin?To-Do in a separate PR: