fix: handle empty cases in edge bundling

[pieh]

🎉 Thanks for submitting a pull request! 🎉

Summary

Potential alternative to #6657 , this time following handling we already have for serverless functions for early bail if there are no functions to bundle

build/packages/build/src/plugins_core/functions/index.ts

Lines 173 to 193 in 70dcaf8

	logFunctionsToBundle({
	logs,
	userFunctions,
	userFunctionsSrc: relativeFunctionsSrc,
	userFunctionsSrcExists: functionsSrcExists,
	internalFunctions,
	internalFunctionsSrc: relativeInternalFunctionsSrc,
	frameworkFunctions,
	generatedFunctions: getGeneratedFunctionsByGenerator(generatedFunctions),
	})
	if (
	userFunctions.length === 0 &&
	internalFunctions.length === 0 &&
	frameworkFunctions.length === 0 &&
	generatedFunctions.length === 0
	) {
	return {}
	}
	const { bundlers } = await zipFunctionsAndLogResults({

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures
  we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
  something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures
  your code follows our style guide and passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[github-actions]

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

[pieh]

content of this function was just inlined in step function directly to get easy access to found edge functions to be able to bail early if there are no functions at all

[eduardoboucas]

LGTM.

I think there's also the case where function directories do exist but there are no registered routes. For us to bail there, I guess we'd need to do it in edge-bundler?

[pieh]

I think there's also the case where function directories do exist but there are no registered routes.

Isn't what this PR does now that even if source dirs exist, but contain no functions we would not be generating edge bundles? There are added test fixtures and tests for that. If added test cases don't contain a case you thinking of here - can you describe a setup to test?

For us to bail there, I guess we'd need to do it in edge-bundler?

Bailing in edge-bundler was initial attempt in #6657, but as mentioned by Phil in #6657 (comment) because there is no early bail like that in edge-bundler now, adding one would be a breaking change (which is not a blocker, but requires more work from all consumers of the package and because we could come up with alternative for scenarios we were thinking of without breaking change - I went with that)