Skip to content

fix: add missing --allow-import flag to deno run command in bundle function #6684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

fix: add missing --allow-import flag to deno run command in bundle function #6684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
284b8c1
chore: run tarball test for using npm and remote modules with edge bu…
JakeChampion Sep 24, 2025
831b34c
fix: add missing --allow-import flag to deno run command in bundle fu…
JakeChampion Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/edge-bundler/node/bundler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ test('Loads edge functions from the Frameworks API', async () => {
await cleanup()
})

describe.skipIf(lt(denoVersion, '2.4.2'))(
describe.skipIf(lt(denoVersion, '2.4.3'))(
'Produces a tarball bundle',
() => {
test('With only local imports', async () => {
Expand Down Expand Up @@ -790,8 +790,7 @@ describe.skipIf(lt(denoVersion, '2.4.2'))(
await rm(vendorDirectory.path, { force: true, recursive: true })
})

// TODO: https://github.com/denoland/deno/issues/30187
test.todo('Using npm modules', async () => {
test('Using npm and remote modules', async () => {
const systemLogger = vi.fn()
const { basePath, cleanup, distPath } = await useFixture('imports_npm_module', { copyDirectory: true })
const sourceDirectory = join(basePath, 'functions')
Expand Down
1 change: 1 addition & 0 deletions packages/edge-bundler/node/formats/tarball.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export const bundle = async ({
importMap.withNodeBuiltins().toDataURL(),
'--quiet',
'--code-splitting',
'--allow-import',
'--outdir',
bundleDir.path,
...functions.map((func) => func.path),
Expand Down
Loading