Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrading memoize-one to 5.2.1 #2218

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

alexreardon
Copy link
Contributor

Context: #2202

memoize-one@5.2.0 introduced an unintentional breaking change to the CommonJS bundle. 5.2.0 has been deprecated, and 5.2.1 removes the named import to revert the breaking change to the CommonJS bundle.

This PR simply bumps you back to 5.2.1 and moves away from the named import which is no longer supported (as 5.2.0 has been deprecated)

@alexreardon
Copy link
Contributor Author

alexreardon commented Apr 24, 2021

I am pretty sure this is not done 100% correctly as it looks like there node_modules/@netlify/build in package-lock.json is using ^5.2.0

@JGAntunes JGAntunes changed the title chore(fix): upgrading memoize-one to 5.2.1 fix(deps): upgrading memoize-one to 5.2.1 Apr 24, 2021
@JGAntunes
Copy link
Contributor

Thanks @alexreardon, this should take care of half of it and netlify/build#2653 will address the rest of the problem 👍 I'll go ahead and merge this.

@JGAntunes JGAntunes added the type: bug code to address defects in shipped code label Apr 24, 2021
@JGAntunes JGAntunes merged commit c2bfeae into netlify:main Apr 24, 2021
@alexreardon alexreardon deleted the memoize-one-5.2.1 branch April 24, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants