chore: convert unlink command #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
force-pushed
the
CP-476/convert-api-command
branch
from
8596b3f
to
96688c6
Compare
khendrikse
force-pushed
the
CP-486/convert-unlink-command
branch
from
886f6e1
to
f3708b1
Compare
Base automatically changed from
CP-476/convert-api-command
to
CP-101/design-system-clack-implementation
January 11, 2024 15:40
khendrikse
force-pushed
the
CP-486/convert-unlink-command
branch
from
f3708b1
to
4b6a22c
Compare
khendrikse
force-pushed
the
CP-486/convert-unlink-command
branch
from
4b6a22c
to
cd87408
Compare
khendrikse
merged commit 5f03f68
into
CP-101/design-system-clack-implementation
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes: https://linear.app/netlify/issue/CT-486/convert-unlink-command-to-clack
This converts the unlink command into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.
Before:
After:
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)