chore: convert log command #6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note to say this branch now includes code to convert the open command to clack |
src/commands/logs/functions.ts
Outdated
| } | ||
|
|
||
| const levelsToPrint = options.level || LOG_LEVELS_LIST | ||
|
|
||
| const { functions = [] } = await client.searchSiteFunctions({ siteId }) | ||
|
|
||
| if (functions.length === 0) { | ||
| log(`No functions found for the site`) | ||
| return | ||
| NetlifyLog.error(`No functions found for the site`) |
There was a problem hiding this comment.
Think we need to exit here
| const { result } = await inquirer.prompt({ | ||
| name: 'result', | ||
| type: 'list', | ||
| const result = await select({ |
There was a problem hiding this comment.
I've managed to narrow down the failing tests to this select prompt but I have no idea why that would cause the timeouts. Digging further...
There was a problem hiding this comment.
Ah it's because we previously mocked the interaction for inquirer but we need to do the same here for the clack prompt
lemusthelroy
approved these changes
Jan 19, 2024
lemusthelroy
merged commit d8e422c
into
CP-101/design-system-clack-implementation
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes: https://linear.app/netlify/issue/CT-479/convert-logs-command-to-clack
This converts the
logscommand into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.#6325 was also merged into this branch which converts the open command to clack
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)