Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set DEPLOY_ID and DEPLOY_URL env vars once available #6489

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Apr 2, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Resolves https://linear.app/netlify/issue/COM-426/deploy-url-doesnt-update-when-deploying-locally-via-cli


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@Skn0tt Skn0tt self-assigned this Apr 2, 2024
@Skn0tt Skn0tt requested a review from a team as a code owner April 2, 2024 12:53
Copy link

github-actions bot commented Apr 2, 2024

📊 Benchmark results

Comparing with edbfbb4

  • Dependency count: 1,312 (no change)
  • Package size: 294 MB ⬆️ 0.00% increase vs. edbfbb4
  • Number of ts-expect-error directives: 1,016 ⬇️ 0.10% decrease vs. edbfbb4

@Skn0tt Skn0tt enabled auto-merge (squash) April 8, 2024 09:49
@Skn0tt Skn0tt merged commit bc24f77 into main Apr 8, 2024
40 checks passed
@Skn0tt Skn0tt deleted the set-deploy-id-env-var-once-available branch April 8, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants