Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert get-port dependency update #6531

Conversation

lemusthelroy
Copy link
Contributor

@lemusthelroy lemusthelroy commented Apr 25, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

The get-port dependency update has been reverted back to 5.1.1 as users were reporting that they were not able to acquire ports that they required as part of their development workflow. One such port that was affected was 443, but others around that range were also affected.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested a review from a team as a code owner April 25, 2024 20:37
Copy link

📊 Benchmark results

Comparing with 6655e52

  • Dependency count: 1,329 (no change)
  • Package size: 310 MB ⬇️ 0.00% decrease vs. 6655e52
  • Number of ts-expect-error directives: 1,001 (no change)

@lemusthelroy lemusthelroy merged commit e10ef23 into main Apr 25, 2024
40 checks passed
@lemusthelroy lemusthelroy deleted the lemusthelroy/ct-1102-cli-not-acquiring-port-443-when-running-ntl-dev-port-443 branch April 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants