Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make feature flags available to @netlify/config #6691

Merged
merged 40 commits into from
Jun 14, 2024

Conversation

lemusthelroy
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

By constructing our API client earlier, this PR feeds the feature flags into @netlify/config where the flags are required

Fixes #<replace_with_issue_number>
https://linear.app/netlify/issue/CT-1291/ensure-cli-passes-feature-flags-to-netlifyconfig


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested a review from a team as a code owner June 5, 2024 14:30
Copy link

github-actions bot commented Jun 5, 2024

📊 Benchmark results

Comparing with 0f69e06

  • Dependency count: 1,317 (no change)
  • Package size: 480 MB ⬇️ 0.00% decrease vs. 0f69e06
  • Number of ts-expect-error directives: 978 (no change)

DanielSLew
DanielSLew previously approved these changes Jun 5, 2024
khendrikse
khendrikse previously approved these changes Jun 6, 2024
Copy link
Contributor

@khendrikse khendrikse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@lemusthelroy lemusthelroy marked this pull request as draft June 7, 2024 10:26
@lemusthelroy lemusthelroy marked this pull request as ready for review June 7, 2024 12:19
@eduardoboucas
Copy link
Member

This is touching production code, so it shouldn't be a chore:. Can we please rename before merging?

@khendrikse khendrikse changed the title chore: make feature flags available to @netlify/config feat: make feature flags available to @netlify/config Jun 12, 2024
src/commands/base-command.ts Outdated Show resolved Hide resolved
src/commands/serve/serve.ts Show resolved Hide resolved
@lemusthelroy
Copy link
Contributor Author

I have pushed a commit on this by accident

Copy link
Contributor

@khendrikse khendrikse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am loving this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants