Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev server: activity #6709

Closed
wants to merge 4 commits into from
Closed

Dev server: activity #6709

wants to merge 4 commits into from

Conversation

davbree
Copy link
Contributor

@davbree davbree commented Jun 16, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Tweak which requests are considered activity. Now we filter out redirects (including to internal plugins) and non-GET requests.

ref CRE-1189


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@davbree davbree requested a review from a team as a code owner June 16, 2024 09:04
Copy link

📊 Benchmark results

Comparing with 1706c8c

  • Dependency count: 1,317 (no change)
  • Package size: 480 MB ⬇️ 0.00% decrease vs. 1706c8c
  • Number of ts-expect-error directives: 978 (no change)

@davbree davbree closed this Jun 16, 2024
@davbree davbree deleted the devserver-activity-3 branch June 16, 2024 09:33
@davbree davbree restored the devserver-activity-3 branch June 16, 2024 09:34
@davbree davbree deleted the devserver-activity-3 branch June 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant