Upgrade zip-it-and-ship-it and js-client
#768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
dependencies
|
Tested and working fine. Thanks for the PR @ehmicky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
zip-it-and-ship-itto the latest version used inside Netlify Build.This new version should be backward compatible, although it has not been tested with many real users yet.
This will ensure Netlify Build users are using consistent versions for
zip-it-and-ship-itsince that library is used separately by several projects: Netlify Build, Netlify CLI and the JavaScript client, which are requiring each other.If there are issues in the beta version of
zip-it-and-ship-it, it is better for us to catch those with local builds than with production builds.This PR also upgrades to the latest major of the
js-client. That major version only adds one thing: upgrading to the latestzip-it-and-ship-itas well (see netlify/js-client#90). This PR put both upgrades together to ensure the same version ofzip-it-and-ship-itis used whether used directly or through thejs-client.Before merging this, @RaeesBhatti are there any chances you could manually test it locally (anything related to Functions, such as deploying then, etc.)? Thanks a lot!