Git Gateway support for BitBucket #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benaiah
changed the title
Benaiah
commented
Jul 19, 2018
api/bitbucket.go
Outdated
| } | ||
|
|
||
| func rewriteLinksInBitBucketResponse(resp *http.Response, endpointAPIURL, proxyAPIURL string) error { | ||
| body, err := ioutil.ReadAll(resp.Body) |
There was a problem hiding this comment.
This needs to correctly handle gzipped content - it currently causes an error if you request gzipped content.
calavera
reviewed
Jul 20, 2018
api/bitbucket.go
Outdated
| switch resp.Header.Get("Content-Encoding") { | ||
| case "gzip": | ||
| bodyReader, err = gzip.NewReader(resp.Body) | ||
| defer bodyReader.Close() |
There was a problem hiding this comment.
the defer probably needs to go after checking the error.
calavera
reviewed
Jul 20, 2018
api/bitbucket.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| w.Close() |
There was a problem hiding this comment.
this should go after w := szip.NewWriter with a defer
calavera
reviewed
Jul 20, 2018
api/bitbucket.go
Outdated
| } | ||
|
|
||
| newBody, err := json.Marshal(b) | ||
| println(newBody) |
|
@calavera updated with requested changes. |
|
So do we have git gateway support with bitbucket ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Adds BitBucket support to Git Gateway, including logic to refresh access tokens using a provided refresh token, OAuth client ID, and OAuth client secret.
This PR needs link rewriting added before it's merged.Link rewriting has been added.- Test plan
Tested manually.
- Description for the changelog
Git gateway support for BitBucket