Skip to content

Remove Client-IP header if present when proxying to gitlab #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

mraerino
Copy link
Contributor

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Copy link

@jose-ledesma jose-ledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, maybe I would change the log to Debug/remove it (because I don't think this log line may add any value in the future)

@mraerino mraerino merged commit 73e35ca into master Nov 19, 2019
@mraerino mraerino deleted the fix/remove-invalid-header branch November 19, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants