This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Add negated orderHistory parameters and deleteUsers method #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New method created for the deletion of one or many users Allowed negated parameters for the order history method
bcomnes
changed the title
bcomnes
suggested changes
Dec 10, 2018
|
I'll go ahead and make the tweak. |
|
Oh wait we can't do that, parames is already an object. |
bcomnes
approved these changes
Dec 10, 2018
|
Ok, instead of adding a single additional argument, I wrapped them in an options object so we have room to grow. |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method created for the deletion of one or many users:
gocommerce #149
Allowed negated parameters for the order history method:
gocommerce #152
Closes #21
Closes #20