Allow deletion of multiple users #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraerino
force-pushed
the
feature/user-bulk-delete
branch
from
136a10a
to
580ee69
Compare
bcomnes
approved these changes
Oct 25, 2018
mraerino
force-pushed
the
feature/user-bulk-delete
branch
from
580ee69
to
0b34805
Compare
Expects a DELETE call agains `/users` with a query like `?id=x&id=y`. This action is idempotent. Deletion of non-existent users will not throw an error.
mraerino
force-pushed
the
feature/user-bulk-delete
branch
from
0b34805
to
d66c61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
- Summary
In order to delete multiple users issue a
DELETEcall to/users.Multiple
idquery parameters will determine which users should be deleted.Example:
This is the closest you get to implementing bulk deletion in REST.
It should also be compatible to how qs (js lib) handles a parameter with multiple values. (Use
{ indices: false }in the options.)This action is meant to be idempotent:
If you pass ids which don't exist it will not result in an error. This enables sending the same request multiple times if the first request failed and only some users got deleted. Although internally it uses a transaction to rollback changes if one delete fails, idempotency is still a best practice for this.
- Test plan
There is a new test suite
TestUserBulkDeletewith 5 different test cases.- Description for the changelog
Allow deletion of multiple users