This repository was archived by the owner on Oct 10, 2022. It is now read-only.
align js-client upload limits with api ones #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingride
added
type: chore
ehmicky
approved these changes
Oct 20, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
part of aligning our concurrency limits across our platform, we need to update the js-client to reflect the same values as enforced by our API https://github.com/netlify/bitballoon/issues/5842 and https://github.com/netlify/bitballoon/issues/5624 (internal)
This is a fix for #178 - thank you @kaganjd for opening the issue ❤️
- Test plan
This shouldn't impact current deploy behaviour as this limit has been enabled since the 9th of September at the API level.
- Description for the changelog
Limiting abusive client uploads by enforcing a unified concurrency limit for js-clients across the Netlify Platform
- A picture of a cute animal (not mandatory but encouraged)
